Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated comments #218

Closed
pscott opened this issue Jun 26, 2023 · 1 comment
Closed

Outdated comments #218

pscott opened this issue Jun 26, 2023 · 1 comment

Comments

@pscott
Copy link
Collaborator

pscott commented Jun 26, 2023

Some of the documentation (comments) are outdated due to the recent changes. For example, the comment describing the WhitelistVotingstrategy.getVotingPower function is wrong, since it still specifies the addresses must be in ascending order. Also, the return parameter is not described correctly, since it reverts in case the user isn't whitelisted (doesn't return 0).
@Orland0x
Copy link
Contributor

ive done the whitelist ones. not sure whether there are others.

@pscott pscott closed this as completed Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pscott @Orland0x