Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: Voting Power Not Easily Estimated in User Interface #193

Closed
Orland0x opened this issue Jun 13, 2023 · 0 comments · Fixed by #210
Closed

audit: Voting Power Not Easily Estimated in User Interface #193

Orland0x opened this issue Jun 13, 2023 · 0 comments · Fixed by #210
Assignees

Comments

@Orland0x
Copy link
Contributor

In the current implementation, estimating the voting power for each voting strategy of a space before casting a vote is challenging. The issue lies with the getVotingPower() method in the voting strategy contracts, which is not a view function and can perform state changes due to the potential need for resolving the timestamp, in CompVotingStrategy and OZVotesVotingStrategy.
This makes it hard for the user interface to call the function for estimation purposes without sending a transaction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant