audit: Same Proposal Status for Queued, Executed or Vetoed Proposals

[Orland0x]

In TimelockExecutionStrategy and CompTimelockCompatibleExecutionStrategy, executing or vetoing a transaction has the same observable effect of setting the executionTime of the payload to 0. Different events (ProposalVetoed vs ProposalExecuted) are emitted, but the proposal status as reported by getProposalStatus will in both cases be Executed. An on-chain actor will have no way to tell if a queued proposal has been executed or vetoed.

[Orland0x]

From the POV of the space, the proposal has been executed even if it gets later vetoed. So this seems okay.

[pscott]

From the POV of the space, the proposal has been executed even if it gets later vetoed. So this seems okay.

It does feel cleaner to provide the correct information to the caller.. maybe the space doesn't care but another on-chain actor would care?

[Orland0x]

how would we do it though? we dont store the proposal id in the timelock. Feels like an edge case that if someone really cared they could write their own custom strat

[pscott]

Yeah I agree there's not much we can do :p