Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audit: add quorum to the avatar setup event #206

Merged
merged 1 commit into from
Jun 15, 2023
Merged

audit: add quorum to the avatar setup event #206

merged 1 commit into from
Jun 15, 2023

Conversation

pscott
Copy link
Collaborator

@pscott pscott commented Jun 15, 2023

  • Add quorum to the avatar creation event
  • Check that the event gets fired up properly

Closes #187

@pscott pscott requested a review from Orland0x June 15, 2023 14:58
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #206 (8683fef) into main (c73eb71) will decrease coverage by 1.10%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
- Coverage   83.25%   82.15%   -1.10%     
==========================================
  Files          29       29              
  Lines         442      454      +12     
  Branches      112      114       +2     
==========================================
+ Hits          368      373       +5     
- Misses         57       65       +8     
+ Partials       17       16       -1
Impacted Files Coverage Δ
...c/execution-strategies/AvatarExecutionStrategy.sol 63.15% <0.00%> (ø)

... and 6 files with indirect coverage changes

Orland0x
Orland0x approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@Orland0x Orland0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uTACK

@Orland0x Orland0x merged commit b7ff1ef into main Jun 15, 2023
@Orland0x Orland0x deleted the audit_add_quorum_to_avatar_event branch October 11, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Orland0x Orland0x Orland0x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

audit: Quorum Not Included in the AvatarExecutionStrategySetUp Event Emission
2 participants
@pscott @Orland0x