Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audit: Quorum Not Included in the AvatarExecutionStrategySetUp Event Emission #187

Closed
Orland0x opened this issue Jun 13, 2023 · 1 comment · Fixed by #206
Closed

audit: Quorum Not Included in the AvatarExecutionStrategySetUp Event Emission #187

Orland0x opened this issue Jun 13, 2023 · 1 comment · Fixed by #206
Assignees
@pscott

Comments

@Orland0x
Copy link
Contributor

The AvatarExecutionStrategySetUp event, emitted in the setUp function, does not include the _quorum parameter in its emission. Although it is initialized correctly and stored in the contract state, this omission could lead to potential issues with transparency and event tracking.
@pscott pscott self-assigned this Jun 14, 2023
@pscott pscott mentioned this issue Jun 15, 2023
Merged
@pscott
Copy link
Collaborator

pscott commented Jun 15, 2023

fix:

  • Add quorum to the avatar creation event
  • Check that the event gets fired up properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pscott pscott

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

audit: add quorum to the avatar setup event snapshot-labs/sx-evm
2 participants
@pscott @Orland0x