Prevent updating if proposal is too close to voting period start #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #202 +/- ##
=======================================
Coverage 83.37% 83.37%
=======================================
Files 29 29
Lines 451 451
Branches 113 113
=======================================
Hits 376 376
Misses 57 57
Partials 18 18
|
Orland0x
deleted the
audit_prevent_updating_if_proposal_is_to_close_to_voting_period
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify updateProposal to make it revert if the block timestamp is too close to the beginning of the vote.
too close is defined as 15 minutes (can be chagned before we merge). It is currently a constant but we could decide to make it a setting and add some
setterfor it.Closes #186