Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: Potential Reentrancy in executeQueuedProposal Method #185

Closed
Orland0x opened this issue Jun 13, 2023 · 0 comments · Fixed by #215
Closed

audit: Potential Reentrancy in executeQueuedProposal Method #185

Orland0x opened this issue Jun 13, 2023 · 0 comments · Fixed by #215
Assignees

Comments

@Orland0x
Copy link
Contributor

The executeQueuedProposal function, as present in both CompTimelockCompatibleExecutionStrategy and TimelockExecutionStrategy, is susceptible to potential reentrancy issues. While the method does not allow the same proposal to be executed twice by resetting the execution time to zero before any external calls, this does not protect from different proposals executing their meta-transactions in an interleaved order if one of them calls untrusted code. This could lead to unexpected outcomes, particularly when executing proposals with dependencies or conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants