Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audit: No Setter for Delay in TimelockExecutionStrategy #213

Merged
merged 2 commits into from
Jun 20, 2023
Merged

audit: No Setter for Delay in TimelockExecutionStrategy #213

merged 2 commits into from
Jun 20, 2023

Conversation

Orland0x
Copy link
Contributor

closes #184

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #213 (44fda83) into main (5c51bbe) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
+ Coverage   80.82%   80.91%   +0.08%     
==========================================
  Files          28       28              
  Lines         459      461       +2     
  Branches      111      111              
==========================================
+ Hits          371      373       +2     
  Misses         73       73              
  Partials       15       15
Impacted Files Coverage Δ
...execution-strategies/TimelockExecutionStrategy.sol 80.43% <100.00%> (+0.88%) ⬆️

pscott
pscott approved these changes Jun 19, 2023
View reviewed changes
Copy link
Collaborator

@pscott pscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes sir
tACK

@Orland0x Orland0x merged commit 39fb3a0 into main Jun 20, 2023
@Orland0x Orland0x deleted the audit_timelock_delay branch October 11, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pscott pscott pscott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

audit: No Setter for Delay in TimelockExecutionStrategy
2 participants
@Orland0x @pscott