audit: use uint256 instead of bool in mappings #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #208 +/- ##
=======================================
Coverage 80.82% 80.82%
=======================================
Files 28 28
Lines 459 459
Branches 111 111
=======================================
Hits 371 371
Misses 73 73
Partials 15 15
|
|
looks good, theres also the salts mapping in |
Yeah found 1-2 additional occurrences that I fixed. Cheers for reminding me to check the whole codebase :) |
Orland0x
reviewed
Jun 16, 2023
…t_inefficient_boolean_mappings
* audit: prevent reentrancy issues in execute function * comment: add comment for cached proposal * comment: remove comment for finalization status modification * chore: CEI explanation * chore: typo --------- Co-authored-by: Orlando <[email protected]>
* refactor: timestamps to numbers in space * refactor: block numbers in proposal status funcs * refactored: removed timestamp resolver * refactor: proposal validation to use block nubmers * refactor: removed snapshot block number * chore: updated tests * refactor: make getVotingPower a view function * refactor: revert active proposal limiter to timestamps * refactor: revert timelocks to timestamps * chore: fixed tests * Update IVotingStrategy.sol chore: natspec typo --------- Co-authored-by: Orlando <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #182