Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audit: Inconsistency in Quorum Modifiability #205

Merged
merged 11 commits into from
Jun 15, 2023
Merged

audit: Inconsistency in Quorum Modifiability #205

merged 11 commits into from
Jun 15, 2023

Conversation

pscott
Copy link
Collaborator

@pscott pscott commented Jun 15, 2023

  • Add setQuorum for Optimistic / Emergency / Simple quorums
  • Update Emergency quorum to use an initializer
  • Add tests to ensure it all works as expected

Closes #181

@pscott pscott requested a review from Orland0x June 15, 2023 13:50
@Orland0x Orland0x changed the title Add setQuorum for Quorum functions audit: Inconsistency in Quorum Modifiability Jun 15, 2023
Orland0x
Orland0x approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@Orland0x Orland0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uTACK

@Orland0x Orland0x merged commit 5b87623 into main Jun 15, 2023
@Orland0x Orland0x deleted the audit_inconsistency_in_quorum branch October 11, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Orland0x Orland0x Orland0x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

audit: Inconsistency in Quorum Modifiability
2 participants
@pscott @Orland0x