Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: Inconsistency in Quorum Modifiability #181

Closed
Orland0x opened this issue Jun 13, 2023 · 1 comment · Fixed by #205
Closed

audit: Inconsistency in Quorum Modifiability #181

Orland0x opened this issue Jun 13, 2023 · 1 comment · Fixed by #205
Assignees

Comments

@Orland0x
Copy link
Contributor

SimpleQuorumExecutionStrategy defines a storage variable for the quorum. It could be useful to
add a setter for the quorum, as it could be useful to change it depending on the circulating voting power.
Moreover, there is an inconsistency between SimpleQuorumExecutionStrategy and EmergencyQuorumStrategy in how they handle the quorum variable. In the latter it is set as an immutable. This prevents contracts deriving from EmergencyQuorumStrategy to be deployed as proxies.

@pscott pscott self-assigned this Jun 14, 2023
@pscott
Copy link
Collaborator

pscott commented Jun 14, 2023

Fix:

  • Remove immutable keyword from in EmergencyQuorumStrategy
  • Update EmergencyQuorumStrategy to use the initializer like Simple and Optimistic ones
  • Add setQuorum / setEmergencyQuorum functions in those contracts
  • Add tests for these newly added functions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants