Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: Function Visibility Can Be Restricted #180

Closed
Orland0x opened this issue Jun 13, 2023 · 0 comments · Fixed by #198
Closed

audit: Function Visibility Can Be Restricted #180

Orland0x opened this issue Jun 13, 2023 · 0 comments · Fixed by #198

Comments

@Orland0x
Copy link
Contributor

The visibility of the following functions can be restricted in order to save gas:

  1. The Space contract's initialize function can be made external.
  2. The SpaceManager contract's enableSpace and disableSpace functions could be made external. Alternatively, an internal and external copy of the functions could exist, if inheriting contracts should have access to these functions. Additionally, the isSpaceEnabled function could be made external, and internal uses (e.g. the onlySpace modifier) should directly access the spaces mapping to save gas.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant