Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename env var names #211

Open
mktcode opened this issue Dec 6, 2021 · 0 comments
Open

Rename env var names #211

mktcode opened this issue Dec 6, 2021 · 0 comments

Comments

@mktcode
Copy link
Contributor

mktcode commented Dec 6, 2021

NETWORK

const networkStr = network === 'testnet' ? 'demo.' : '';
proposal.link = `https://${networkStr}snapshot.org/#/${proposal.space.id}/proposal/${proposal.id}`;

SNAPSHOT_URI:

deep_link: `${process.env.SNAPSHOT_URI}/#/${event.space}/${event.id}`

and now there's DEFAULT_NETWORK:

This is a bit confusing but NETWORK could actually be removed and replaced by SNAPSHOT_URI. It does nothing more than building the frontend URL for proposal links and/or push notifications.

Originally posted by @mktcode in #210 (comment)

@mktcode mktcode changed the title Confusing env var names Rename env var names Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant