You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Using implode in Smarty templates throws a deprecation warning, even when used with the correct argument order.
For example: {implode(',', $array)}
Despite being valid syntax, this still triggers a warning. Replacing implode() with join() and reversed argument order resolves the issue, but this requires changes to existing templates, which may not be ideal.
I believe, the deprecation warning should only be triggered if the arguments are provided in the incorrect order. If the syntax is correct, no warning should be raised.
I suggest trigger_errow should only be called if incorrect order of arguments is provided.
Or would like clarification: Is implode officially deprecated in Smarty in favour of join (which actually an alias in php), or is this an unintended side effect? Is so, then overriding the default extensions could be a viable workaround: #1048
The text was updated successfully, but these errors were encountered:
Using implode in Smarty templates throws a deprecation warning, even when used with the correct argument order.
For example:
{implode(',', $array)}
Despite being valid syntax, this still triggers a warning. Replacing
implode()
withjoin()
and reversed argument order resolves the issue, but this requires changes to existing templates, which may not be ideal.I believe, the deprecation warning should only be triggered if the arguments are provided in the incorrect order. If the syntax is correct, no warning should be raised.
I suggest
trigger_errow
should only be called if incorrect order of arguments is provided.smarty/src/Extension/DefaultExtension.php
Line 562 in 5d1ea58
Or would like clarification: Is implode officially deprecated in Smarty in favour of join (which actually an alias in php), or is this an unintended side effect? Is so, then overriding the default extensions could be a viable workaround: #1048
The text was updated successfully, but these errors were encountered: