Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and combine pgdraw and pgdrawv interface #14

Open
slinderman opened this issue Jul 14, 2017 · 0 comments
Open

Simplify and combine pgdraw and pgdrawv interface #14

slinderman opened this issue Jul 14, 2017 · 0 comments

Comments

@slinderman
Copy link
Owner

As @tansey pointed out, we could combine these interfaces and make them more familiar to numpy users by making pgs (i.e. the vector to be populated with samples upon output) an optional input. If it is None, we allocate an array and return it, otherwise we populate it. This would not break the current functionality, and would be more consistent with numpy functions that support an out argument.

We could do the same for the pgdrawvpar function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant