Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in DucklingPlugin's activate_latent_entities. #124

Open
keshav47 opened this issue Feb 18, 2022 · 1 comment
Open

Bug in DucklingPlugin's activate_latent_entities. #124

keshav47 opened this issue Feb 18, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@keshav47
Copy link
Contributor

keshav47 commented Feb 18, 2022

Describe the bug
In DucklingPlugin, once self.activate_latent_entities is set True, there is no option to make it False in the consecutive turns/states where I don't want latent entities.

Following logic in DucklingPlugin contributes to this behavior.

self.activate_latent_entities = use_latent or self.activate_latent_entities

here

To Reproduce
Steps to reproduce the behavior:

  1. set activate_latent_entities=false , while defining DucklingPlugin inside processors.
  2. Set state wise latent_entities in Input Class. eg latent_entities=False for capture_date_state and latent_entities=True for capture_time_state
  3. print(activate_latent_entities) variable inside Dialogy DucklingPlugin Base Class.
  4. curl request slu with payload's context['current_state'] in the following sequence capture_date_state -> capture_time_state -> capture_date_state
  5. activate_latent_entities will be printed in this sequence False -> True -> True

Expected behavior
Whereas it should have been:
False -> True -> False

Screenshots
Na

Desktop (please complete the following information):

  • OS: Ubuntu
  • Python version: 3.9

Additional context
Na

@keshav47 keshav47 added the bug Something isn't working label Feb 18, 2022
@ltbringer
Copy link
Contributor

Refer to latent_entities field in the Input class. activate_latent_entities will become a private variable in a short period.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants