Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support #18

Open
Sergey-Orlov opened this issue Dec 2, 2016 · 3 comments
Open

Windows support #18

Sergey-Orlov opened this issue Dec 2, 2016 · 3 comments

Comments

@Sergey-Orlov
Copy link
Contributor

For windows support I have to made next changes:

.env

  • COMPOSE_FILE=./src/docker/docker-compose.yml;./src/docker/docker-compose.override.yml instead of COMPOSE_FILE=./src/docker/docker-compose.yml:./src/docker/docker-compose.override.yml

Makefile

  • remove \ from $(shell cp -n \.env.default \.env)
  • remove \ from $(shell cp -n \.\/src\/docker\/docker-compose\.override\.yml\.default \.\/src\/docker\/docker-compose\.override\.yml)
  • add -d flag to each docker-compose exec command
  • remove sudo from sudo rm -rf build

This way docker build all containers, but still have issue with shared folder (it shares from docker VM, not windows)

@gaydabura
Copy link
Member

i guess for windows support we need a new branch of this repo

pabloguerino added a commit to pabloguerino/skilld-docker-container that referenced this issue Mar 22, 2017
@pabloguerino
Copy link
Contributor

added quick PR to give support for Windows,

.env

COMPOSE_FILE variable wasn't manipulated as it's inside .env, but we could run sed against it and replace the chars we need, is it worth it ? I think no.

remove sudo from sudo rm -rf build

for sudo didn't find anything on this Makefile, but we could use the WINDOWS variable (is either 1 or 0) and check if we need sudo or not.

This way docker build all containers, but still have issue with shared folder (it shares from docker VM, not windows)

need more info / testing, will check on this if needed but will take time for sure.

@pabloguerino
Copy link
Contributor

PR: #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants