-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button sizing when in group #2003
Comments
@bartcuijpers can you expand with an example. In most cases I'm aware of the group controls the sizing. |
The requested example was not replied so I'm closing this due to inactivity. If an example is provided in the future I'm happy to reopen. But currently it's not clear what's being requested here. |
Individual buttons can be sized using the |
@campbelljlowman thanks, this should be something we can support. I appreciate the detailed explanation. |
While working with this I've noticed another behavior that I think could be considered a bug. If I have a button group and want to change the color of one of them to indicate it's been selected using a different variant class, it works, however if I hover over the highlighted button, the background color goes back to the button group color. This is confusing when trying to change the color of the button to indicate it's been clicked, because the background will stay the previous color until the user moves their cursor off the button. I confirmed this is not the case with regular buttons. Not sure if this is the correct place to discuss |
Right, we've seen this behavior before. The trick is to make sure to apply <div class="btn-group variant-filled">
<button>Months</button>
<button class="!variant-filled-primary">Days</button>
<button>Years</button>
</div> This is somewhat related, but I'd also encourage you keep an eye out for this change in the new release next week. This resolves the disabled state for child buttons in a button group: |
In an effort to prepare for Skeleton v3, we're consolidate some related issues down to a single ticket. This will ensure that we can see the full context of requests when the time comes to refactor and update this feature going forward. If you wish to add additional feedback or suggestions, please so here: |
Describe the feature in detail (code, mocks, or screenshots encouraged)
It seems impossible to adjust the button sizing when they are grouped. It would be a nice additional feature.
What type of pull request would this be?
None
Provide relevant links or additional information.
No response
The text was updated successfully, but these errors were encountered: