Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Screenshot function #261

Open
rcarmo opened this issue Jan 15, 2025 · 6 comments
Open

Feature Request - Screenshot function #261

rcarmo opened this issue Jan 15, 2025 · 6 comments

Comments

@rcarmo
Copy link

rcarmo commented Jan 15, 2025

Hi! It would be great if we could take screenshots of a device and download them in PNG or JPEG format

@clipcarl
Copy link

Is this really needed when the browser can already save images of what's displayed? For example in Firefox I can shift-right-click on the NanoKVM window and select "Take Snapshot" or "Take Screenshot" to get a screenshot of what's displayed.

@rcarmo
Copy link
Author

rcarmo commented Feb 2, 2025

Yes, of course it is needed. Not everyone uses Firefox (in fact, sadly, less and less people do), and if you are using the KVM to write documentation then you are likely to take multiple screenshots during a session (many KVMs also have a recording function). This, by the way, is a feature that has been in the first PiKVM for years.

@clipcarl
Copy link

clipcarl commented Feb 2, 2025

Obviously, it's not just Firefox that can do page screenshots. You can do them in Chrome through the developer tools and there are multiple extensions that make it easy. Same with every other major browser.

Further, every major OS has a way to screenshot windows or rectangular areas which are available at the tap of a single keypress. So I'm not sure why the NanoKVM developers need to reinvent the wheel for a feature that's already incredibly easy to accomplish two other ways.

@rcarmo
Copy link
Author

rcarmo commented Feb 2, 2025

I don't think we have the same use case scenarios (or control) for where and when these things are used, or with which clients. You assume people have the flexibility or skills to do that through other means without (apparently) being anywhere near involved with the project.

Suffice it to say that a) this is a feature that is relied upon for documentation b) it is built in to other KVMs c) it is not rocket science to implement.

@clipcarl
Copy link

clipcarl commented Feb 2, 2025

Suffice it to say that a) this is a feature that is relied upon for documentation

Yes, I've used it extensively for that purpose myself. And the OS screenshot tool works perfectly for that.

b) it is built in to other KVMs

I'm not sure this is true. I don't remember seeing this option in any of the web browser based IPMI (or external) KVMs I've worked with. I think the web browser based ones just assume you can use the browser or OS for screenshots.

c) it is not rocket science to implement.

Yeah, it's easy to say that when it's not your time and money. If you really meant it you'd develop the feature yourself and send in a patch.

@clipcarl
Copy link

clipcarl commented Feb 2, 2025

Image

One tap of a key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants