Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revoke token #491

Open
wd15 opened this issue Dec 1, 2022 · 5 comments
Open

Revoke token #491

wd15 opened this issue Dec 1, 2022 · 5 comments

Comments

@wd15
Copy link

wd15 commented Dec 1, 2022

Can an existing token be revoked with the Surge CLI? surge token --help doesn't give any indications of possible sub-commands.

@danielfdsilva
Copy link

In light of Circle CI's security incident this would be really needed.

@brint
Copy link

brint commented Jan 11, 2023

I was digging through the code and found this:

'url': url.resolve(req.endpoint, "/token/reset/" + req.email),

By doing a password reset on my account, I was able to get a new token after the password reset.

@danielfdsilva
Copy link

@brint Unfortunately this does not revoke the old token.
Here's how I tested it:

Got a token with surge token, logged out and reset the password. Tried the previously issued token by doing surge list --token <token> and it was still working.

@alexgleason
Copy link

Bump

@mauricioklein
Copy link

I confirm that /token/reset doesn't reset the token.

curl -vvv -XPOST https://surge.surge.sh/token/reset/[my email here]

Got a 201 back (with no authentication whatsoever 🤯), but token remains the same.

If at least we got access to their API documentation, we would have a workaround until the CLI is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants