Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking: Limit assertion log to a reasonable default #2562

Closed
fatso83 opened this issue Oct 25, 2023 · 2 comments
Closed

breaking: Limit assertion log to a reasonable default #2562

fatso83 opened this issue Oct 25, 2023 · 2 comments
Milestone
v18

Comments

@fatso83
Copy link
Contributor

fatso83 commented Oct 25, 2023 •
edited
Loading

Ref #2484 and #2485 we should set a default assertion log limit to limit Sinon's output. 10K characters was suggested in the original PR.
@fatso83 fatso83 added this to the v18 milestone Oct 25, 2023
@stale Stale
Copy link

stale bot commented Dec 27, 2023

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Dec 27, 2023
@fatso83 fatso83 changed the title Limit assertion log to a reasonable default breaking: Limit assertion log to a reasonable default Sep 10, 2024
@stale stale bot removed the wontfix label Sep 10, 2024
@fatso83
Copy link
Contributor Author

fatso83 commented Sep 12, 2024

We did end up changing it to 10k in that PR

@fatso83 fatso83 closed this as completed Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v18
Development

No branches or pull requests
1 participant
@fatso83