You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed this with my face-detect service on kovan, which publishes all the face related proto files in one directory. It is only passed, via react props, the call details for face-align, because it is the first item in the array returned by service-spec-provider.
As it stands, this makes the "Service Name" drop down in the DefaultService UI component meaningless.
I still believe we should only allow one grpc service to be specified per SNet service, but until that's reflected across all our tools we should make the dapp pass all the service details.
In the mean time I will make seperate directories of proto/grpc definitions and republish my services.
I will be republishing my services, but I will leave snet/face-identity service the same so you can debug
Since the logic for parsing the service spec is duplicated in every single UI component, this would also be a great opportunity to refactor it into one place! #79
raamb
transferred this issue from singnet/snet-betav1-dapp
Sep 23, 2019
service-spec-provider returns an array of grpc services, but the dapp just takes the first one:
https://github.com/singnet/snet-dapp/blob/master/src/components/JobDetails.js#L103
I noticed this with my face-detect service on kovan, which publishes all the face related proto files in one directory. It is only passed, via react props, the call details for
face-align
, because it is the first item in the array returned by service-spec-provider.As it stands, this makes the "Service Name" drop down in the DefaultService UI component meaningless.
I still believe we should only allow one grpc service to be specified per SNet service, but until that's reflected across all our tools we should make the dapp pass all the service details.
In the mean time I will make seperate directories of proto/grpc definitions and republish my services.
I will be republishing my services, but I will leavesnet/face-identity
service the same so you can debughttps://protojs.singularitynet.io/kovan/snet/face-identityEdit: Sorry, I have republished face-identity so you can no longer test with it.
Here is also an example response from service-spec-provider:
The text was updated successfully, but these errors were encountered: