Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No documentation for new update prop as well as a bug #19

Open
northkode opened this issue Oct 5, 2022 · 0 comments
Open

No documentation for new update prop as well as a bug #19

northkode opened this issue Oct 5, 2022 · 0 comments

Comments

@northkode
Copy link

I think there is a bug with 2.1.1 version.

The singleSpaProps object that is online 49 is null.. and the chooseDomElementGetter function passing in opts and singleSpaProps but if singleSpaProps == null the code completely dies and crashes the app

image

image

This should be optional and default to a blank {} object then line 92 - 97 would run for backwards compatibility
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant