New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DynamicTypingRecentsStream does not handle pagination #84

Open

ahumeau opened this issue Dec 1, 2020 · 0 comments

ahumeau commented Dec 1, 2020

Hi all,

I encountered this situation when my Pipedrive organizations started exceeding 100 fields : the new ones would not be replicated.

The reason Pipedrive API fields endpoint have a limit of 100.
My workaround was to pass a higher limit when requesting the fields endpoints:

# In tap_pipedrive/streams/recents/dynamic_typing/__init__.py
fields_response = self.tap.execute_request(endpoint=self.fields_endpoint, params={'limit': 200})

A better solution would be to handle pagination but I do not know if it is worth it as this is quite a edge case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment