Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Count and MaxCount of modifiers are float64 #204

Open
Kisa75 opened this issue Aug 31, 2023 · 0 comments
Open

Count and MaxCount of modifiers are float64 #204

Kisa75 opened this issue Aug 31, 2023 · 0 comments
Assignees
@unleashurgeek @Kisa75

Comments

@Kisa75
Copy link
Collaborator

Kisa75 commented Aug 31, 2023 •
edited
Loading

The Count and MaxCount field of modifiers is typed as float64 but should be int. Exisisting implementations using modifiers should be fixed if they relied on them being float64.

https://github.com/simimpact/srsim/blob/main/pkg/engine/modifier/modifier.go#L19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@unleashurgeek unleashurgeek

@Kisa75 Kisa75

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@unleashurgeek @Kisa75