Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TurnOrder, GetActiveTarget helpers #271

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

kdovtdc
Copy link
Collaborator

@kdovtdc kdovtdc commented Aug 22, 2024

  • added TurnOrder helper to engine
  • added GetActiveTarget helper to engine

useful for implementations requiring check for turn order, such as BTBIO
closes #187

useful for implementations requiring check for active target
closes #210

uses existing `TurnOrder` implementation in `Turn` package
* added `TurnOrder` to `Turn` interface in `engine`
* exposed `TurnOrder` in simulation layer
useful for implementations requiring check for turn order, such as BTBIO
@kdovtdc kdovtdc changed the title Turnorder helper TurnOrder helper Sep 17, 2024
@kdovtdc kdovtdc changed the title TurnOrder helper Add TurnOrder helper Sep 24, 2024
* added `GetActiveTarget` to `Turn` interface in `engine`
* exposed `GetActiveTarget` in simulation layer
* added `GetActiveTarget` to mock by running `MockGen`

useful for implementations requiring check for active target, such as BTBIO
closes simimpact#210
@kdovtdc kdovtdc changed the title Add TurnOrder helper Add TurnOrder, GetActiveTarget helpers Sep 28, 2024
* added `activeTarget` field to `mockTurnManager`
* updated `StartTurn` to set `activeTarget` field for manager
* implemented `GetActiveTarget` in mock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add TurnOwner helper method to Engine Add TurnOrder method to engine
1 participant