Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silx compare - typo #3942

Closed
payno opened this issue Sep 28, 2023 · 5 comments
Closed

silx compare - typo #3942

payno opened this issue Sep 28, 2023 · 5 comments
Milestone

Comments

@payno
Copy link
Member

payno commented Sep 28, 2023

Looks like there is a small typo on a set definition. Get the following error:

TypeError: set expected at most 1 argument, got 2
ERROR:silx.app.compare.CompareImagesWindow:Error while loading URL bambou_hercules_0001_rec_2058.800_00000.hdf5?/entry0000/reconstruction/results/data
Traceback (most recent call last):
  File "/home/lesaint/envs/tomotools/lib/python3.9/site-packages/silx/app/compare/CompareImagesWindow.py", line 116, in _updateImageB
    data = self.readData(urlPath)
  File "/home/lesaint/envs/tomotools/lib/python3.9/site-packages/silx/app/compare/CompareImagesWindow.py", line 141, in readData
    if data.ndim == 3 and data.shape[0] in set(3, 4):
TypeError: set expected at most 1 argument, got 2
lesaintjerome added a commit to lesaintjerome/silx that referenced this issue Sep 28, 2023
Fix python set(3,4) command with set([3,4]).
@t20100 t20100 added this to the 2.0.0 milestone Sep 28, 2023
@lesaintjerome
Copy link
Contributor

lesaintjerome commented Sep 28, 2023

OK. I probably need to be more precise on the issue. The error happened when with

silx compare "bambou_hercules_0001_rec_2040.800_00000.hdf5?path=/entry0000/reconstruction/results/data" "bambou_hercules_0001_rec_2058.800_00000.hdf5?path=/entry0000/reconstruction/results/data"

, i.e. with no slice number. But when the command

silx compare "bambou_hercules_0001_rec_2040.800_00000.hdf5?path=/entry0000/reconstruction/results/data&slice=0" "bambou_hercules_0001_rec_2058.800_00000.hdf5?path=/entry0000/reconstruction/results/data&slice=0"

is used (i.e. with slice number), then it works fine. That's why I thought stacks were possible....

@lesaintjerome
Copy link
Contributor

It would be nice to have the possibility to compare stacks (with a slider to run through the slices, simultaneously in both stacks). Might be an enhancement request?

@t20100
Copy link
Member

t20100 commented Sep 29, 2023

Might be an enhancement request?

Yes as it is AFAIR stacks are not supported.

Yet, you encountered a bug with RGB(A) images.

@vallsv
Copy link
Contributor

vallsv commented Oct 2, 2023

BTW i don't think stacks are supported

vallsv added a commit that referenced this issue Oct 2, 2023
@vallsv
Copy link
Contributor

vallsv commented Oct 2, 2023

Closed by #3943

@vallsv vallsv closed this as completed Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants