From bf2690344c26ff41243b2d46c845ee9cd79c4ec5 Mon Sep 17 00:00:00 2001 From: Federico Chiariotti Date: Fri, 13 Nov 2020 19:00:03 +0100 Subject: [PATCH] Overloaded method fix in QUIC BBR --- model/quic-bbr.cc | 15 ++++++++++++++- model/quic-bbr.h | 12 ++++++++++-- 2 files changed, 24 insertions(+), 3 deletions(-) diff --git a/model/quic-bbr.cc b/model/quic-bbr.cc index de67f38..34820a5 100644 --- a/model/quic-bbr.cc +++ b/model/quic-bbr.cc @@ -1,7 +1,8 @@ /* -*- Mode:C++; c-file-style:"gnu"; indent-tabs-mode:nil; -*- */ /* * Copyright (c) 2018 NITK Surathkal, - * Copyright (c) 2020 SIGNET Lab, Department of Information Engineering, University of Padova + * 2020 SIGNET Lab, Department of Information Engineering, + * University of Padova * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 as @@ -525,6 +526,8 @@ QuicBbr::UpdateBtlBw (Ptr tcb, const struct RateSample * rs) } } + + void QuicBbr::UpdateModelAndState (Ptr tcb, const struct RateSample * rs) { @@ -608,6 +611,16 @@ QuicBbr::CongControl (Ptr tcb, const struct RateSample *rs) UpdateControlParameters (tcb, rs); } +void +QuicBbr::CongControl (Ptr tcb, + const TcpRateOps::TcpRateConnection &rc, + const TcpRateOps::TcpRateSample &rs) +{ + NS_LOG_FUNCTION (this << tcb); + NS_UNUSED (rc); + NS_UNUSED (rs); +} + void QuicBbr::CongestionStateSet (Ptr tcb, const TcpSocketState::TcpCongState_t newState) diff --git a/model/quic-bbr.h b/model/quic-bbr.h index 595a78a..e755507 100644 --- a/model/quic-bbr.h +++ b/model/quic-bbr.h @@ -1,7 +1,8 @@ /* -*- Mode:C++; c-file-style:"gnu"; indent-tabs-mode:nil; -*- */ /* - * Copyright (c) 2018 NITK Surathkal, 2020 SIGNET Lab, Department of - * Information Engineering, University of Padova + * Copyright (c) 2018 NITK Surathkal, + * Copyright (c) 2020 SIGNET Lab, Department of Information Engineering, + * University of Padova * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 as @@ -105,6 +106,13 @@ class QuicBbr : public QuicCongestionOps virtual void IncreaseWindow (Ptr tcb, uint32_t segmentsAcked); virtual Ptr Fork (); + + /** + * \brief Unused function, added here to avoid overloading the one in TcpCongestionOps + */ + virtual void CongControl (Ptr tcb, + const TcpRateOps::TcpRateConnection &rc, + const TcpRateOps::TcpRateSample &rs); protected: void OnPacketAcked (Ptr tcb, Ptr ackedPacket);