From 00b95e0fc24152a55d9bf93f532d6ad2cbc59fd0 Mon Sep 17 00:00:00 2001 From: signebedi Date: Mon, 2 Sep 2024 13:08:04 -0500 Subject: [PATCH] Fixed: misconfigured API_ENABLED defaults (#329) --- libreforms_fastapi/utils/config.py | 2 +- libreforms_fastapi/utils/scripts.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libreforms_fastapi/utils/config.py b/libreforms_fastapi/utils/config.py index 0840e74..e5dfd5f 100644 --- a/libreforms_fastapi/utils/config.py +++ b/libreforms_fastapi/utils/config.py @@ -303,7 +303,7 @@ def validate_mongodb_uri(cls, v): # These configurations govern over the bifurcation of server and client instances, along with UI_ENABLED above. # For more on decoupling server and client, see https://github.com/signebedi/libreforms-fastapi/issues/329 - API_ENABLED: bool = os.getenv('API_ENABLED:', 'False') == 'True' + API_ENABLED: bool = os.getenv('API_ENABLED:', 'True') == 'True' REMOTE_API_ADDR: AnyUrl | None = os.getenv('REMOTE_API_ADDR:', None) REMOTE_API_KEY: str | None = os.getenv('REMOTE_API_KEY:', None) diff --git a/libreforms_fastapi/utils/scripts.py b/libreforms_fastapi/utils/scripts.py index a76da49..87a3e9b 100644 --- a/libreforms_fastapi/utils/scripts.py +++ b/libreforms_fastapi/utils/scripts.py @@ -161,11 +161,11 @@ def validate_mongodb_configuration(config): raise ConfigurationError("MongoDB URI cannot be an empty string ('MONGODB_URI') when MongoDB is enabled ('MONGODB_ENABLED' = True).") def validate_api_configuration(config): - if config.API_ENABLED: + if not config.API_ENABLED: if not config.REMOTE_API_ADDR: - raise ConfigurationError("The 'REMOTE_API_ADDR' configuration must be set when 'API_ENABLED' is True. Please check your configuration.") + raise ConfigurationError("The 'REMOTE_API_ADDR' configuration must be set when 'API_ENABLED' is False. Please check your configuration.") if not config.REMOTE_API_KEY: - raise ConfigurationError("The 'REMOTE_API_KEY' configuration must be set when 'API_ENABLED' is True. Please check your configuration.") + raise ConfigurationError("The 'REMOTE_API_KEY' configuration must be set when 'API_ENABLED' is False. Please check your configuration.") # Main function to check all configurations def check_configuration_assumptions(config):