Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new coredb ID entries #47

Closed
jfy133 opened this issue Nov 26, 2021 · 2 comments · Fixed by #49
Closed

Add support for new coredb ID entries #47

jfy133 opened this issue Nov 26, 2021 · 2 comments · Fixed by #49

Comments

@jfy133
Copy link
Member

jfy133 commented Nov 26, 2021

Recently apparently a new field was added to many of the tabs with the Eva labs coreDB ID

We should include this when people are pulling tables

@nevrome
Copy link
Member

nevrome commented Jan 30, 2022

Alright - so the name of the column seems to be CoreDB_Id and it occurs in TAB_Sample, TAB_Extract, TAB_Library and TAB_Capture. Do you know why not in TAB_Sequencing?

Right now it's just read as a string column, which is already fine. But we probably still want to add it to our column reference table.

NA values are just empty strings - and this column has naturally a lot of them. This brings us again to to the question if we should improve our data-types and value parsing system some day (#16, #42).

@jfy133
Copy link
Member Author

jfy133 commented Jan 30, 2022

Nope no clue ..

Good point about empty values. Maybe we should just ask Robert to give us a list of every (relevant) column and what the missing value indicator is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants