Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for for comparing bundlesize against branches other than master #217

Open
jakebolam opened this issue Apr 15, 2018 · 2 comments
Open

Comments

@jakebolam
Copy link
Contributor

Do you want to request a feature or report a bug?
feature

What is the current behavior?
Bundlesize always compares against master

If this is a feature request, what is motivation or use case for changing the behavior?
A powerful feature of bundlesize is its comparison to master. It would be useful to support use cases where the branch being merged is not against master. E.g. you're merging a branch into another branch. This would also allow support for workflows which involve develop/staging/hotfixes which is common when pure CI/CD cannot be reached and processes require 'release' candidates.

Proposed implementation

  1. Flag on CLI or ENV which dictates which branch to compare against. e.g. UPSTREAM_BRANCH
  2. Update store to account for this. I'm not sure of the current limits on the firebase store, but this work would also include logic to ensure you can't store more than a certain amount of UPSTREAM_BRANCH data, e.g. 20, deleting the last unused/least relevant data on a new update.

@siddharthkp let me know your thoughts and I'll get a PR up ASAP.

@quantizor
Copy link
Contributor

We'd love this functionality now that 4.0 is under active development for styled-components! We're using a non-master branch for it.

@Drapegnik
Copy link

@jakebolam, @siddharthkp @pvdlg/env-ci allow read prBranch for AppVeyor, CircleCI, Drone, Semaphore, Travis CI, Wercker and more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants