-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clockwork debugger blank because of expires.conf #144
Comments
Hi! What did you remove exactly? (did you delete that file? or remove reference to h5bp from nginx config file? something else?) I'm not sure the expires file makes the most sense since it just affects what headers Nginx returns when serving the file (but doesn't contain any rules blocking the serving of any files). |
Hey Chris, thanks for speedy reply. I forgot to mention I opened this in reference to #itsgoingd/clockwork#340 I've commented out these three: # cache.appcache, your document html and data
location ~* \.(?:manifest|appcache|html?|xml|json)$ {
expires -1;
}
# Media: images, icons, video, audio, HTC
location ~* \.(?:jpg|jpeg|gif|png|ico|cur|gz|svg|svgz|mp4|ogg|ogv|webm|htc)$ {
expires 1M;
access_log off;
add_header Cache-Control "public";
}
# CSS and Javascript
location ~* \.(?:css|js)$ {
expires 1y;
access_log off;
} Then rebuild the app container, and it started to work. Also verified that it stops working again when reintroducing those three locations in the |
Thanks! I don't really get why that caused an issue, perhaps the browser cached the fact that it couldn't find those files? We'll be updating this project to use Ubuntu 20.04 fairly soon, which might be a good time to remove/not use cache rules (especially since Vessel is meant for local dev). |
Yeah it's weird, but probably to do with how Clockwork delivers the files, as they aren't in the public dir of Laravel. Good to hear about 20.04! Love Vessel btw, using it exclusively. Thanks for your hard work :) PS: figured it should stay open haha, or close it if you prefer that. |
Description
I've installed the Clockwork debugger: https://underground.works/clockwork/#docs-installation
When accessing the local Clockwork app under http://localhost/__clockwork/app it gives a blank screen, and debug tools in browser show that all Clockwork images,js and css files return a 404.
Tracked the problem down to
docker/app/h5bp/location/expires.conf
, specifically the expires rule for images, json and js/css files.When removed, and then
vessel down
followed byvessel build app
Clockwork starts working.My knowledge of nginx config is a bit rusty, so I'm unsure what could be done to fix this.
Hoping we can integrate a fix so that I don't have to manually do this every time I install or update Clockwork? 👯♂️
OS
macOS Catalina 10.15.4
My OS is:
Docker
The output of
docker version
:The output of
docker-compose version
:The text was updated successfully, but these errors were encountered: