Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display funding/sponsor links for grammars and themes? #906

Open
jtbandes opened this issue Jan 24, 2025 · 2 comments
Open

Display funding/sponsor links for grammars and themes? #906

jtbandes opened this issue Jan 24, 2025 · 2 comments

Comments

@jtbandes
Copy link

jtbandes commented Jan 24, 2025

Hi there,
Since Shiki uses grammars and themes produced by many open source authors, I was wondering if you would be interested in displaying funding/sponsorship links directly in the docs or website somewhere?

Locally I developed a POC to modify github.ts to fetch the FUNDING.yml files for each referenced repo. What I found is:

  • 17 of the tm-themes have a FUNDING.yml
  • 37 of the tm-grammars have a FUNDING.yml

(the number of unique ones is a bit smaller because some people are authors of a few different themes/grammars).

I think we could consider displaying these "❤️" links:

(It would also need to parse the funding info according to docs and determine what links to display.)

If you think this is a good idea, I can clean up and submit a PR with my changes to fetch the funding info and some of the other modifications too. Looking forward to hear your thoughts!

@antfu
Copy link
Member

antfu commented Jan 25, 2025

All sounds good! First we need to include that field in the source: https://github.com/shikijs/textmate-grammars-themes

Looking forward to that!

@jtbandes
Copy link
Author

Ready for initial feedback :) shikijs/textmate-grammars-themes#116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants