Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Albort - • If the value of deposits[_localToken][_remoteToken] is insufficient, it can result in an underflow, causing the transaction to revert. #83

Open
sherlock-admin3 opened this issue Sep 25, 2024 · 0 comments

Comments

@sherlock-admin3
Copy link
Contributor

sherlock-admin3 commented Sep 25, 2024

Albort

High

• If the value of deposits[_localToken][_remoteToken] is insufficient, it can result in an underflow, causing the transaction to revert.

Summary

Vulnerability Detail

• If the value of deposits[_localToken][_remoteToken] is insufficient, it can result in an underflow, causing the transaction to revert.
• An attacker might attempt to call finalizeBridgeERC20 with repeated or forged messages, trying to deplete the balance from the deposits mapping.

Impact

Denial of Service Attack: An attacker could prevent legitimate bridging operations, leading to service unavailability.
• Locked Funds: If the deposits balance is incorrectly reduced, it could lead to funds being locked in the contract.

Code Snippet

https://github.com/sherlock-audit/2024-08-tokamak-network/blob/main/tokamak-thanos/packages/tokamak/contracts-bedrock/src/universal/StandardBridge.sol#L335

Tool used

Manual Review

Recommendation

@sherlock-admin4 sherlock-admin4 changed the title Lone Teal Jellyfish - • If the value of deposits[_localToken][_remoteToken] is insufficient, it can result in an underflow, causing the transaction to revert. Albort - • If the value of deposits[_localToken][_remoteToken] is insufficient, it can result in an underflow, causing the transaction to revert. Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant