New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nikhilx0111 - the updateparameter function in keeper.sol will always revert while setting up the keeperOracleParameter.effectiveAfter #77

Open

sherlock-admin3 opened this issue Sep 13, 2024 · 0 comments

sherlock-admin3 commented Sep 13, 2024 •

edited

Loading

nikhilx0111

Medium

the updateparameter function in keeper.sol will always revert while setting up the keeperOracleParameter.effectiveAfter

Summary

the keeperOracleParameter.effectiveAfter is set to currenttimestamp in the update parameter function however it will always revert due to a check

Root Cause

https://github.com/sherlock-audit/2024-08-perennial-v2-update-3/blob/main/perennial-v2/packages/perennial-oracle/contracts/keeper/KeeperFactory.sol#L192

https://github.com/sherlock-audit/2024-08-perennial-v2-update-3/blob/main/perennial-v2/packages/perennial-oracle/contracts/keeper/KeeperFactory.sol#L198

Internal pre-conditions

No response

External pre-conditions

No response

Attack Path

No response

Impact

function will always revert while setting up the effectiveafter to current timestamp

PoC

No response

Mitigation

remove the " = "

if (currentTimestamp < keeperOracleParameter.effectiveAfter) revert KeeperFactoryInvalidParameterError();

sherlock-admin3 changed the title ~~Brave Crimson Yak - the updateparameter function in keeper.sol will always revert while setting up the keeperOracleParameter.effectiveAfter~~ nikhilx0111 - the updateparameter function in keeper.sol will always revert while setting up the keeperOracleParameter.effectiveAfter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment