You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
function will always revert while setting up the effectiveafter to current timestamp
PoC
No response
Mitigation
remove the " = "
if (currentTimestamp < keeperOracleParameter.effectiveAfter) revert KeeperFactoryInvalidParameterError();
The text was updated successfully, but these errors were encountered:
sherlock-admin3
changed the title
Brave Crimson Yak - the updateparameter function in keeper.sol will always revert while setting up the keeperOracleParameter.effectiveAfter
nikhilx0111 - the updateparameter function in keeper.sol will always revert while setting up the keeperOracleParameter.effectiveAfter
Sep 23, 2024
nikhilx0111
Medium
the updateparameter function in keeper.sol will always revert while setting up the keeperOracleParameter.effectiveAfter
Summary
the keeperOracleParameter.effectiveAfter is set to currenttimestamp in the update parameter function however it will always revert due to a check
Root Cause
https://github.com/sherlock-audit/2024-08-perennial-v2-update-3/blob/main/perennial-v2/packages/perennial-oracle/contracts/keeper/KeeperFactory.sol#L192
https://github.com/sherlock-audit/2024-08-perennial-v2-update-3/blob/main/perennial-v2/packages/perennial-oracle/contracts/keeper/KeeperFactory.sol#L198
Internal pre-conditions
No response
External pre-conditions
No response
Attack Path
No response
Impact
function will always revert while setting up the effectiveafter to current timestamp
PoC
No response
Mitigation
remove the " = "
if (currentTimestamp < keeperOracleParameter.effectiveAfter) revert KeeperFactoryInvalidParameterError();
The text was updated successfully, but these errors were encountered: