You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
in market.sol while sending any protocol, oracle, risk, donation, and claimable fee there's no error handling incase of a failed transaction the function will return the fee as claimed leading to loss of fee for the fees claimer
The text was updated successfully, but these errors were encountered:
sherlock-admin3
changed the title
Brave Crimson Yak - no error handling while pushing fees
nikhilx0111 - no error handling while pushing fees
Sep 23, 2024
nikhilx0111
Medium
no error handling while pushing fees
Summary
in market.sol while sending any protocol, oracle, risk, donation, and claimable fee there's no error handling incase of a failed transaction the function will return the fee as claimed leading to loss of fee for the fees claimer
Root Cause
https://github.com/sherlock-audit/2024-08-perennial-v2-update-3/blob/main/perennial-v2/packages/perennial/contracts/Market.sol#L322
https://github.com/sherlock-audit/2024-08-perennial-v2-update-3/blob/main/perennial-v2/packages/perennial/contracts/Market.sol#L323
Internal pre-conditions
No response
External pre-conditions
No response
Attack Path
No response
Impact
loss of accued fee for users
PoC
No response
Mitigation
revert if the fee transfer fails
The text was updated successfully, but these errors were encountered: