252.md

Suave Pebble Giraffe

Medium

The return value of the call is not checked

Summary

The return value of the call is not checked

Vulnerability Detail

When using call to transfer money, the return value needs to be checked, but it is not checked in the contract.

Impact

Transactions will not be reverted due to transfer failures, which would cause the funds to be locked in the contract.

Code Snippet

https://github.com/sherlock-audit/2024-06-boost-aa-wallet/blob/main/boost-protocol/packages/evm/contracts/actions/AContractAction.sol#L39

Tool used

Manual Review

Recommendation

Added checks on return values.

    require(success == true, "call fail");