Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to Access storage.list in CastLabs Electron 28 with Chromium 120 After Offline License Download #7426

Open
ranjithrr opened this issue Oct 15, 2024 · 5 comments
Assignees
Labels
component: offline The issue involves the offline storage system of Shaka Player status: waiting on response Waiting on a response from the reporter(s) of the issue type: bug Something isn't working correctly
Milestone

Comments

@ranjithrr
Copy link

Description:

We are experiencing an issue after updating to CastLabs Electron version 28 (Chromium version 120). Previously, using CastLabs Electron version 27, we could access storage.list data across multiple domains without any problems. However, after the update, this functionality is no longer working as expected.

Steps to Reproduce:

We use Shaka Player version 2.0.0 for offline license download.
We open multiple Electron windows with different domains (e.g., localhost1, localhost2, localhost3) to speed up the offline download license process.
We randomly allocate the files to download the offline license.
After downloading, when playing the content, we open the player on the respective domain to access the relevant IndexedDB data.
We try to access the offline downloaded license through storage.list but receive an empty array.
If we open the console, navigate to the Application tab, and check IndexedDB, we can see the offline downloaded data.
Expected Behavior:

The storage.list should return the data of the offline downloaded licenses, just like it did with CastLabs Electron version 27.
Actual Behavior:

storage.list returns an empty array, even though the data is visible in IndexedDB when manually checked.
Additional Information:

Shaka Player Version: 2.0.0
CastLabs Electron Version: 28
Chromium Version: 120
The same setup worked as expected in CastLabs Electron version 27.
Could there be any recent security changes or restrictions introduced in Electron 28 or Chromium 120 that might be causing this issue?

@ranjithrr ranjithrr added the type: bug Something isn't working correctly label Oct 15, 2024
@shaka-bot shaka-bot added this to the v4.12 milestone Oct 15, 2024
@ranjithrr
Copy link
Author

Would you please help me?

@avelad
Copy link
Member

avelad commented Oct 18, 2024

Version 2.0.0 is no longer supported, see our policy at: https://github.com/shaka-project/shaka-player/blob/main/maintained-branches.md

Please test it with a newer version of Shaka, sorry!

@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Oct 18, 2024
@ranjithrr
Copy link
Author

Used v4.10 as per your recommendation, still same issue , is there any cross domain related changes happed in chromium recent released versions, we are download the offline license in localhost1 stored with same domain in indexedDB, while accessing offline license parent application is launching with localhost and player is loading in ifram with localhost1but storage.list() giving empty array ,please give the solution , is anything related to "StoragePartitioning"

@avelad avelad added the component: offline The issue involves the offline storage system of Shaka Player label Oct 21, 2024
@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Oct 21, 2024
@avelad
Copy link
Member

avelad commented Oct 21, 2024

@joeyparrish can you help here? Thanks!

@avelad avelad modified the milestones: v4.12, v4.13 Nov 13, 2024
@joeyparrish
Copy link
Member

I assume it has to do with the different domains used by your application. You should be able to investigate in the dev console, in the "Application" tab, which lets you see what's stored in IndexedDB.

@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: offline The issue involves the offline storage system of Shaka Player status: waiting on response Waiting on a response from the reporter(s) of the issue type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

4 participants