Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full screen mode does not work on most TVs. #7419

Open
FiberOnePL opened this issue Oct 11, 2024 · 14 comments
Open

Full screen mode does not work on most TVs. #7419

FiberOnePL opened this issue Oct 11, 2024 · 14 comments
Assignees
Labels
component: UI The issue involves the Shaka Player UI flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this platform: TV/STB Issues affecting smart TV or set-top box platforms priority: P3 Useful but not urgent status: waiting on response Waiting on a response from the reporter(s) of the issue type: bug Something isn't working correctly
Milestone

Comments

@FiberOnePL
Copy link

It doesn't work on TV in full screen mode. I checked it on a 2018 Sony and a 2019 Samsung. While it worked correctly on previous versions, now I have a black screen and cursor and nothing happens, in normal mode it works correctly.

@FiberOnePL FiberOnePL added the type: bug Something isn't working correctly label Oct 11, 2024
@shaka-bot shaka-bot added this to the v4.12 milestone Oct 11, 2024
@FiberOnePL
Copy link
Author

The last version that works correctly is v2.5.23, newer versions won't load on TV.

https://index-dot-shaka-player-demo.appspot.com/

The latest shaka demo also loads only a white page on TV.

@avelad
Copy link
Member

avelad commented Oct 18, 2024

Our UI and Demo are not prepared to work on any SmartTV, and we will not support this functionality.

@avelad avelad closed this as completed Oct 18, 2024
@avelad avelad added the status: will not implement The team chooses not to implement this enhancement label Oct 18, 2024
@avelad avelad removed this from the v4.12 milestone Oct 18, 2024
@avelad avelad removed the type: bug Something isn't working correctly label Oct 18, 2024
@FiberOnePL
Copy link
Author

@avelad I wrote that I also checked if it works there, but it doesn't work on either the production version or the demo version, and I checked which latest version works, so you closed this bug without checking.

@FiberOnePL
Copy link
Author

Currently I checked on 11 tv full screen does not work properly. We just get a black screen and nothing happens.

@avelad
Copy link
Member

avelad commented Oct 18, 2024

Version 2.5.X is no longer supported, see our policy at: https://github.com/shaka-project/shaka-player/blob/main/maintained-branches.md

@FiberOnePL
Copy link
Author

@avelad

But it doesn't work on the latest version, and I wrote that the last version on which full screen worked was version 2x. So there is a bug there because on 11 TVs from 2018 to 2022 on various models the full screen does not work.

@FiberOnePL
Copy link
Author

As you can see there are no controls and a black screen. In normal mode everything works fine only in full screen mode it stops working and this does not apply to 1 tv I think most older tvs if a 2 year old tv can be considered old

@joeyparrish
Copy link
Member

I would bet that this could be fixed in CSS, assuming those TVs support the fullscreen API in general. @FiberOnePL, can you get access to dev tools or a debugger on those devices and experiment with the fullscreen styles to help figure out what's wrong?

@joeyparrish joeyparrish reopened this Oct 18, 2024
@joeyparrish joeyparrish added platform: TV/STB Issues affecting smart TV or set-top box platforms component: UI The issue involves the Shaka Player UI type: bug Something isn't working correctly and removed status: will not implement The team chooses not to implement this enhancement labels Oct 18, 2024
@joeyparrish joeyparrish added the priority: P3 Useful but not urgent label Oct 18, 2024
@shaka-bot shaka-bot added this to the Backlog milestone Oct 18, 2024
@FiberOnePL
Copy link
Author

Not really because I haven't had time for anything lately. I'll try to help but as I wrote to you earlier I won't be able to join the team until after the new year.

@FiberOnePL
Copy link
Author

@joeyparrish Do you know any TV emulator on which I can verify this display error?

@joeyparrish
Copy link
Member

No, I don't. I think the ideal tool would be a dev-tools-style remote debugger like Chrome has, but connected to the app running on the TV, so you can see actual CSS impact in realtime as you edit it.

@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Oct 29, 2024
@FiberOnePL
Copy link
Author

@joeyparrish @avelad

Unfortunately, I have no way of connecting to this TV, but I asked other people and about 50 percent reported this error. If you have the ability to verify this problem on your own, that would be great. Unfortunately, I do not have another TV available on which I could diagnose the problem myself.

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Oct 30, 2024
@joeyparrish
Copy link
Member

I don't have a 2018 Sony or a 2019 Samsung. Sorry!

@joeyparrish joeyparrish added the flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this label Oct 31, 2024
@avelad
Copy link
Member

avelad commented Nov 12, 2024

It seems that WebOS for example does not recommend using the Fullscreen API, see https://webostv.developer.lge.com/faq/2024-04-09-how-can-i-set-my-app-to-play-video-in-full-screen 😮

@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: UI The issue involves the Shaka Player UI flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this platform: TV/STB Issues affecting smart TV or set-top box platforms priority: P3 Useful but not urgent status: waiting on response Waiting on a response from the reporter(s) of the issue type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

4 participants