-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nesting PaginationLink/PaginationPrevious/PaginationNext inside PaginationItem produces nested li elements #2154
Labels
Comments
I have the same issue. I will try and make a PR. |
Yes, #2416 |
This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The Issue
The example given in the docs for
Pagination
component wrapsPaginationLink
/PaginationPrevious
/PaginationNext
components with aPaginationItem
. However the code forPaginationLink
actually already wraps the content inside aPaginationItem
, the example will therefore result in a nestedPaginationItem
s (meaning nested li-elements) -- this will lead to React reporting an error during rendering.Possible Solutions
Do not internalize
PaginationItem
inside aPaginationLink
, this way we will have a uniform behavior when constructing a Pagination tree.Fix the example in the doc so that
PaginationLink
/PaginationPrevious
/PaginationNext
are used directly without being wrapped (again) in aPaginationItem
The text was updated successfully, but these errors were encountered: