Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Number=G VCF fields #493

Closed
tomwhite opened this issue Mar 16, 2021 · 0 comments · Fixed by #619
Closed

Support Number=G VCF fields #493

tomwhite opened this issue Mar 16, 2021 · 0 comments · Fixed by #619
Labels
IO Issues related to reading and writing common third-party file formats

Comments

@tomwhite
Copy link
Collaborator

See https://github.com/pystatgen/sgkit/issues/464#issuecomment-790139564 and https://github.com/pystatgen/sgkit/pull/471#issuecomment-789152592 for implementation notes.

Note that math.comb is only available from Python 3.8 onwards, so we may need to use scipy.special.comb.

cc @timothymillar
@tomwhite tomwhite added the IO Issues related to reading and writing common third-party file formats label Mar 16, 2021
@tomwhite tomwhite mentioned this issue Jul 5, 2021
Merged
@mergify mergify bot closed this as completed in #619 Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
IO Issues related to reading and writing common third-party file formats
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support Number=G VCF fields tomwhite/sgkit
1 participant
@tomwhite