You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
iter_connections current returns an iterator of (InputId, OutputId). I believe it would be more consistent to return (OutputId, InputId), and it matches the direction of connections in the graph.
On the other hand it's a bit of an unnecessary breaking change, but it's caught by the type system, and I think this library is young enough that it's worth it.
This was inspired by @philpax 's comment here. I did this here 32aa8d3, but it will conflict with #30, so waiting on that to make a PR.
Sorry about how inter-connected all my proposed changes are 😆
The text was updated successfully, but these errors were encountered:
Indeed, my original idea was to always go Output -> Input, which is the natural order you'd fetch dependencies from, so iter_connections is kind of backwards.
Since InputId and OutputId are typed, this change is breaking but not silently, users will get a clear error and know what to do, so I don't see any issues with it. It's very early for this library so we can afford breaking some APIs for consistency 😄
iter_connections
current returns an iterator of(InputId, OutputId)
. I believe it would be more consistent to return(OutputId, InputId)
, and it matches the direction of connections in the graph.On the other hand it's a bit of an unnecessary breaking change, but it's caught by the type system, and I think this library is young enough that it's worth it.
This was inspired by @philpax 's comment here. I did this here 32aa8d3, but it will conflict with #30, so waiting on that to make a PR.
Sorry about how inter-connected all my proposed changes are 😆
The text was updated successfully, but these errors were encountered: