Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shouldn't hit external sites without NETWORK_TESTING set #243

Open
coke opened this issue Jun 30, 2023 · 0 comments
Open

Shouldn't hit external sites without NETWORK_TESTING set #243

coke opened this issue Jun 30, 2023 · 0 comments

Comments

@coke
Copy link

coke commented Jun 30, 2023 •
edited
Loading

e.g.

lives-ok { $res = $ua.get('http://httpbin.org/status/404') }, "no exception - expect 404";

from t/*82* - I just had a lengthy zef install fail because this test returned a 502 briefly. During a rerun with --serial install activated, it worked fine.

NETWORK_TESTING seems to be the standard in this kind of testing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@coke