Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sitemaps api #114

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix sitemaps api #114

wants to merge 3 commits into from

Conversation

wumpus
Copy link
Contributor

@wumpus wumpus commented Sep 9, 2019

in py2, robot.sitemaps returns a list. in py3 it returns whatever comes out of map which is some kind of iter.

this pr changes it to always return a list.

Fixes #109

@dlecocq
Copy link
Contributor

dlecocq commented Sep 9, 2019

The change looks good, but I'm not sure why the submodule got updated? Was it out of date?

@wumpus
Copy link
Contributor Author

wumpus commented Sep 9, 2019

I know nothing about submodules.

@dlecocq
Copy link
Contributor

dlecocq commented Sep 9, 2019

I can push a branch preserving your commits, but resolving the submodule issue. Otherwise, you could give this a shot:

# Ensure all the submodules are initialized and checked out at the current SHAs
git submodule update --init --recursive
(
  cd reppy/rep-cpp
  git pull --rebase origin master
  # Update the googletest submodule
  git submodule update --init --recursive
)

git add reppy
git commit --amend

And thanks for the PR, btw!

@wumpus
Copy link
Contributor Author

wumpus commented Sep 9, 2019

Hm, that left me with a repo that can't push -- not really worth debugging, though.

@dlecocq dlecocq mentioned this pull request Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

robots.sitemaps is a map object instead of a list
2 participants