Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Legal Vocabulary is Implemented Twice #9

Open
MartinKoelbl opened this issue Nov 5, 2022 · 1 comment
Open

bug: Legal Vocabulary is Implemented Twice #9

MartinKoelbl opened this issue Nov 5, 2022 · 1 comment
Assignees
@DennisRoemmich
Labels
invalid This doesn't seem right

Comments

@MartinKoelbl
Copy link
Collaborator

No description provided.

@MartinKoelbl
Copy link
Collaborator Author

MartinKoelbl commented Nov 5, 2022 •
edited by DennisRoemmich
Loading

Description

The legal vocabulary diagram is implemented twice. Once in LegalUml.java and also in legal.xsd
There are also a German LegalUmlGerman.java and Recht.xsd

Solution

Keep legal.xsd to parse English contracts. In order to parse German contracts use a German-English translation list to translate the keywords to English and use then legal.xsd to parse the contract.

Tasks

  • Remove UML diagram in LegalUml.java
  • Remove Recht.xsd.
  • Check English legal keywords in legal.xsd are in LegalUml
  • Check a mapping between German and English legal keywords exists in LegalUmlGerman

@MartinKoelbl MartinKoelbl changed the title buf: bug: Legal Vocabulary is Implemented Twice Nov 5, 2022
@MartinKoelbl MartinKoelbl added bug Something isn't working invalid This doesn't seem right and removed bug Something isn't working labels Nov 5, 2022
@DennisRoemmich DennisRoemmich self-assigned this Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DennisRoemmich DennisRoemmich

Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

9-bug-legal-vocabulary-is-implemented-twice sen-uni-kn/ContractCheck
2 participants
@MartinKoelbl @DennisRoemmich