Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code refactoring is needed #2

Open
honeycrypto opened this issue Jun 27, 2019 · 0 comments
Open

Code refactoring is needed #2

honeycrypto opened this issue Jun 27, 2019 · 0 comments

Comments

@honeycrypto
Copy link
Collaborator

There are some duplicated pieces of code which should be moved to helpers.
All promises must reject in case of errors.
try catch is required for all requests to remote servers (semux node, exchanges, other)
Move all hardcoded constants (URLs, min fee, ..) to a config file.
Code review.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@honeycrypto