getRawPacketReadOnly() const-correctness

[luizfeldmann]

Hi,

It seems that both the read-only and non-read-only getters of the raw packet from the parsed packet have the exact same signature and behaviour:

RawPacket* getRawPacket() const;
RawPacket* getRawPacketReadOnly() const;

Wouldn't it be more correct to declare the read-only getter as returning a pointer-to-const, and similarly, the non-read-only method not be marked as const method as it can alter the underlying object ?

RawPacket* getRawPacket();
const RawPacket* getRawPacketReadOnly() const;

Best regards,

[tigercosmos]

Yes, it's a bug.

[egecetin]

@luizfeldmann Feel free to open a PR to fix it if you have time. Contributions are welcome!