Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor code review #4

Open
ErickTalarico opened this issue Feb 7, 2021 · 0 comments
Open

minor code review #4

ErickTalarico opened this issue Feb 7, 2021 · 0 comments

Comments

@ErickTalarico
Copy link

GeostatisticsDiscreteDriver.py : yields an error at line 45, because the parameter l (correlation range) is int, while function IndicatorKriging checks it is a float (line 127). The authors should check for int or float

GeostatisticsDiscreteDriver.py: figure 4, subplot 1: the title should be "Indicator Kriging Probability for facies 0". Without it the user might think it is the probability of facies 1 because the higher values are yellow, just like yellow is the color for facies 1.

GeostatisticsDiscreteDriver.py: figure 4, subplot 2: the title should be "Indicator Kriging most likely facies"

RockPhysicsInversionDriver.py: there should be titles in each figure to help the user understand what method is being used

SeismicInversionDriver.py: lines 82 and 83: substitute the function np.matlib.repmat with np.tile. At least my numpy version did not have this function (maybe it is deprecated), while np.tile worked.

ESSeisInversionDriver.py: there should be titles on the figures 2 and 3 to help the user understand what he is looking at (prior realizations and posterior, respectively)

ESPetroInversionDriver.py: include legend in the figures to help understand what is being plotted.

leandrofgr added a commit that referenced this issue May 27, 2021
Fix code style issue with black
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant