Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segment is not sending the Push notification token to Adjust correctly #20

Open
fmessina opened this issue Mar 27, 2019 · 0 comments
Open

Comments

@fmessina
Copy link

fmessina commented Mar 27, 2019

The Segment integration with Adjust is never sending the push token to Adjust.

After debugging this I discovered that the following method on the SEGAdjustIntegration.m is never called.

- (void)registerForRemoteNotificationsWithDeviceToken:(NSData *)deviceToken
                                              options:(NSDictionary *)options
{
    [Adjust setDeviceToken:deviceToken];
}

In fact there is a log from Segment saying

Not sending call to Adjust because it doesn't respond to registeredForRemoteNotificationsWithDeviceToken:.

The method signature should be instead

- (void)registeredForRemoteNotificationsWithDeviceToken:(NSData *)deviceToken
{
    [Adjust setDeviceToken:deviceToken];
}

This is quite critical cause we need to be sure to send the push token to Adjust correctly without integrating their native SDK (using only the Segmend/Adjust integration)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant