Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JavaScript action to speed up the execution #163

Open
machulav opened this issue Dec 30, 2020 · 1 comment
Open

Use JavaScript action to speed up the execution #163

machulav opened this issue Dec 30, 2020 · 1 comment

Comments

@machulav
Copy link

machulav commented Dec 30, 2020

I noticed that the execution time of your action takes around 25 seconds which seems quite a lot for such a simple thing.
In the logs, I found that only the container build process takes 22 seconds. When the actual action execution takes less than a second. See screenshot below.

image

By using JavaScript action instead of Docker container action you can get rid of those 22 seconds of the build time and speed up your action significantly.

In order to do that you just need to keep one compiled execution file with all the dependencies in your repo. And such a tool like ncc can easily help you with that.

And that's important as my application container build takes almost the same time. I don't talk about the linter which pulls the code, installs all the dependencies, and lints all the code for twice less time than I lint my PR name.

image

@maor-rozenfeld
Copy link

maor-rozenfeld commented Mar 25, 2024

Been 3 years but I simply implemented it in bash -

https://github.com/marketplace/actions/prlint-reloaded

However the action is still slower than the old lambda implementation...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants